Fix/replace deprecated include module #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…certificate As of Ansible 2.10, the 'openssl_certificate' was moved to the 'community.crypto' collection and the 'assertonly' provider was removed. See: https://docs.ansible.com/ansible/latest/collections/community/crypto/x509_certificate_module.html#synopsis
- changing requirements to be Ansible 2.10.0+ - updating usage to use role version 3.0.0 - adding missing commas
to improve compatibility with newer ansible versions. this commit is not changing all module names though, this still to be finalized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
includemodule has been deprecated in Ansible2.12, and completely removed in Ansible2.16(https://github.com/ansible/ansible/blob/v2.16.0/changelogs/CHANGELOG-v2.16.rst#removed-features-previously-deprecated).Replacing it with
include_tasksandimport_tasksfixes the issue. Both were introduced in Ansible2.4so this should not be a braking change (see: https://docs.ansible.com/ansible/2.9/modules/include_tasks_module.html and https://docs.ansible.com/ansible/2.9/modules/import_tasks_module.html#import-tasks-module).This pull request also includes commits which were already added last year, they were tagged with
3.0.0-alpha1and3.0.0-alpha2, but I don't know why they don't seem to be part of themasterbranch.