-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in the Japanese translations to the release branch. #457
Open
jaydeetay
wants to merge
72
commits into
R1_10_1
Choose a base branch
from
master
base: R1_10_1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanNakhla
suggested changes
Nov 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm what's the purpose of the of the jpgs? Accidental additions?
Seems likely. Looks like it has Polish changes in here too. Since I started this back in January I cannot remember for the life of me what it was for. |
* Includes an image of the eclipse path, courtsey of nasa. * The actual image.
* Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates
* Prep for release. * Make the mandatory changes required by the Google Play Store. (And, while I'm doing that, deal with the mountain of dreary legal paperwork they now tax devs with). * Updated Polish translation (#489) (#491) Co-authored-by: Agnieszka C <[email protected]> * Merge translation updates into release branch (#493) * Updated Polish translation (#489) * Spanish updates (#492) * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates --------- Co-authored-by: Agnieszka C <[email protected]> Co-authored-by: VegaDark <[email protected]> * Update version number * Remove the eclipse map. Update some build settings. --------- Co-authored-by: Agnieszka C <[email protected]> Co-authored-by: VegaDark <[email protected]>
* Prep for release. * Make the mandatory changes required by the Google Play Store. (And, while I'm doing that, deal with the mountain of dreary legal paperwork they now tax devs with). * Updated Polish translation (#489) (#491) Co-authored-by: Agnieszka C <[email protected]> * Merge translation updates into release branch (#493) * Updated Polish translation (#489) * Spanish updates (#492) * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates * Spanish updates --------- Co-authored-by: Agnieszka C <[email protected]> Co-authored-by: VegaDark <[email protected]> * Update version number * Remove the eclipse map. Update some build settings. * Version number bump. * Update android.yml Try updating java version --------- Co-authored-by: Agnieszka C <[email protected]> Co-authored-by: VegaDark <[email protected]>
Try an even more radical upgrade
Try changing the java version for the actual integration test!
version 12 doesn't exist. Go figure.
surely 17==61 should do it.
As per the docs for the emulator step.
dashboard. Latter looks like a framework error.
Instead of just setting the screen brightness to a value we established 15 years ago, give the user some options. They can stick with the classic dimming, use a very very dim setting or (most sensibly) just use the system setting. * Try disabling dimming as an experiment. * This time just disable the dimming, not the red mode. * Adding menu options. But somehow the the screens are messed up with the settings activity not appearing below the title any more. * Working on getting options for the dimness level. * So much boilerplate to inject some activities. * Made other activities dim too.
version bump
Updated Greek translation
Greek translation
…t. (#524) * Plumb through preferences into the layers so that font size can be set. * Plumb in the font change. It's a bit convoluted. * Clean up
bump the version code
Updated Greek translation
Updated Greek translation
…525) * Stashing this * Restore some methods I'd commented out. Obviously at some point I intended to inject the model and then didn't finish the job. This sort of clean up might just be better waiting for the rewrite. * Have the location controller display the location after calculating it on a background thread (the most common cause of ANRs in the app right now). * A couple of tidy ups --------- Co-authored-by: JayDeeTay <[email protected]>
Bump the version code.
…low my own advice.
* Random feature thoughts. * Fixed a newly introduced bug that causes the diagnostics activity to crash with an NPE. --------- Co-authored-by: JayDeeTay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with
gradlew app:connectedGmsDebugAndroidTest
to make sure you didn't break anything (with an emulator running or phone connected)If you have multiple commits please combine them into one commit by squashing them.
Note you may see the Cirrus CI system failing on your PR. It's pretty flaky right now so don't
be alarmed.