[amazonechocontrol] Broken last voice command on Fire TV Cube #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…17 issue) Signed-off-by: Tom Blum [email protected]
Signed-off-by: Tom Blum [email protected]
Signed-off-by: Tom Blum [email protected]
Signed-off-by: Tom Blum <[email protected]>
Signed-off-by: Tom Blum <[email protected]>
J-N-K
reviewed
Oct 10, 2024
| @@ -141,6 +144,8 @@ public class AccountHandler extends BaseBridgeHandler implements PushConnection. | |||
| private boolean disposing = false; | |||
| private @Nullable AccountTO accountInformation; | |||
|
|
|||
| Set<String> deviceSerialNumbers = Collections.synchronizedSet(new LinkedHashSet<>()); | |||
There was a problem hiding this comment.
Why don't you use ConcurrentHashMap.newKeySet()? That's what we usually do if we want to create a new thread-safe Set.
There was a problem hiding this comment.
@Trinitus01 The "final" solution CopyOnWriteArraySet does not work, because it's iterator does not support remove and throws an UnsupportedOperationException. Is there any reason why this is a class field and not a local variable? As far as I can see that would also be possible.
There was a problem hiding this comment.
It seems there is no reason why this is a class field. So we can change it to a local one.
Signed-off-by: Jan N. Klug <[email protected]>
J-N-K
added a commit
that referenced
this pull request
Oct 13, 2024
* fixed: missing Content-Length header (BodyPublisher.ofByteArrays JDK 17 issue) Signed-off-by: Tom Blum [email protected] * fixed: commited line endings Signed-off-by: Tom Blum [email protected] * removed: logger Signed-off-by: Tom Blum [email protected] * fixed: boken last voice command on Fire TV Cube Signed-off-by: Tom Blum <[email protected]> * fixed: spotless aso Signed-off-by: Tom Blum <[email protected]> * review Signed-off-by: Jan N. Klug <[email protected]> --------- Signed-off-by: Tom Blum [email protected] Signed-off-by: Tom Blum <[email protected]> Signed-off-by: Jan N. Klug <[email protected]> Co-authored-by: Jan N. Klug <[email protected]> Signed-off-by: Jan N. Klug <[email protected]>
J-N-K
added a commit
that referenced
this pull request
Oct 13, 2024
* fixed: missing Content-Length header (BodyPublisher.ofByteArrays JDK 17 issue) Signed-off-by: Tom Blum [email protected] * fixed: commited line endings Signed-off-by: Tom Blum [email protected] * removed: logger Signed-off-by: Tom Blum [email protected] * fixed: boken last voice command on Fire TV Cube Signed-off-by: Tom Blum <[email protected]> * fixed: spotless aso Signed-off-by: Tom Blum <[email protected]> * review Signed-off-by: Jan N. Klug <[email protected]> --------- Signed-off-by: Tom Blum [email protected] Signed-off-by: Tom Blum <[email protected]> Signed-off-by: Jan N. Klug <[email protected]> Co-authored-by: Jan N. Klug <[email protected]> Signed-off-by: Jan N. Klug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: boken last voice command on Fire TV Cube
Signed-off-by: Tom Blum [email protected]