Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-edits): add test case for setting context #6592

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

hitesh-1997
Copy link
Contributor

@hitesh-1997 hitesh-1997 commented Jan 10, 2025

Adds the test case for the two issues we faced:

  1. Tab not working when conflicted with edit command decorations. Resolves comment - test cases for PR
  2. Suffix getting duplicated because in addition to inline acceptance, we were modifying the document again on accept - [test case for PR]

Test plan

Added test case

Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙌

Comment on lines +405 to +406
await acceptSuggestionCommand()
expect(editBuilder.size).toBe(0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@hitesh-1997 hitesh-1997 merged commit 764721c into main Jan 12, 2025
20 of 21 checks passed
@hitesh-1997 hitesh-1997 deleted the hitesh/add-test-case-decoration branch January 12, 2025 09:19
@hitesh-1997 hitesh-1997 requested review from akalia25 and removed request for akalia25 January 12, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants