[Java] Update Java samples to consume the new CloudAdapterWithErrorHandler #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batta32
suggested changes
Jul 8, 2021
There was a problem hiding this comment.
- The same changes should be applied in all the classes, check the
Files Changedsection of the PR and you will identify disparities between different samples. getBotFrameworkHttpAdaptoris returningBotFrameworkHttpAdapterthat's ok, but we need to return aCloudAdapteras these samples are not using theAdapterWithErrorHandlernow.
...les/java_springboot/02.echo-bot/src/main/java/com/microsoft/bot/sample/echo/Application.java
Outdated
Show resolved
Hide resolved
Batta32
approved these changes
Jul 8, 2021
…pdate-samples/13-core-bot [Java][13.core-bot] Add missing dependecy
…be consistent with the botbuilder-java solution
…pdate-samples/21-corebot-app-insights [Java][21.corebot-app-insights] Updated CloudAdapterWithErrorHandler constructor initialization
…dd-comment-add-app-sample-42 Added a comment explaining a failing condition
This reverts commit da87810.
…pdate-samples/sample-45-add-import Added missing import to enable using BlobStorage and CosmosDB to sample 45
…pdate-samples/update-sample-52-comments Enhanced the comment to include the expected outcome
…cess local resources without using Attachment()
…pdate-samples/consistency-accessing-local-resources [Java][samples] Implement changes to ensure consistency accessing local resources on all samples
…pdate-samples/49.qnamaker-allfeatures Add QnAAuthKey property in application.properties of sample 49.qnamak…
…pdate-samples/update-readme Update samples README files
…pdate-samples/fix-sample-manifest [Java][53.teams-messaging-extensions-action-preview] Fix manifest file
…pdate-samples/fix-attachment-initialization [Java][samples] Fix samples throwing an error when using local resources
…pdate-samples/fix-sample-47 Fix Middleware usage on Samples
…ersion' into internal/feature/southworks/update-samples/use-cloudadapter-controller
…ersion' into internal/feature/southworks/update-samples/use-cloudadapter-controller
…pdate-samples/update-sdk-version Updated SDK version
…pdate-samples/use-cloudadapter-controller Modify all Java samples to use BotCloudAdapterController
ldardick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Testing