Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples to support Node 22 version - JavaScript #433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sw-joelmut
Copy link

@sw-joelmut sw-joelmut commented Jan 7, 2025

#minor

Description

This PR updates the ARM templates of the JavaScript samples to use Node 22 as default.

Proposed Changes

  • Updated Node to version 22 in all ARM templates for Windows and Linux.

Testing

These images show the bot working after the deployment.
image

Copy link

@ceciliaavila ceciliaavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but the issue 4009 is closed. Let's remove the issue number and include Node 22 in the title so it's evident.

@sw-joelmut sw-joelmut changed the title [#4009] Update samples to support latest Node version - JavaScript Update samples to support Node 22 version - JavaScript Jan 7, 2025
@sw-joelmut
Copy link
Author

done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants