✨ feat: update Dockerfile to improve dependency management and security #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed `pnpm install` to use `--frozen-lockfile` to ensure deterministic installs. - Updated environment variable names to use consistent casing (e.g., `HUGGINGFACE_API_KEY`). - Fixed development image to create the run directory with proper permissions (`chown node:node`). - Switched to a non-root user (`node`) in the development image for better security practices.
gitworkflows
changed the title
|
@gitworkflows sorry for the delay i ntesting this but I do see the following permission denied, when testing on Windows 11: |
thecodacus
reviewed
Dec 17, 2024
| CMD pnpm run dev --host | ||
| # Create run directory with proper permissions | ||
| RUN mkdir -p /app/run && chown node:node /app/run | ||
|
|
There was a problem hiding this comment.
directory was created but files were copied to the /app directory during copy stage. do you need to put this line at the start with a followed by a chdir command?
|
@gitworkflows can you check the last comment from @thecodacus please: #633 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm installto use--frozen-lockfileto ensure deterministic installs.HUGGINGFACE_API_KEY).chown node:node).node) in the development image for better security practices.