server: restore separate connections for the local state db #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #25 I switched away from using a transaction for queries on the local state database, because it did not interact properly with the queryable interface we added in #24. But because I'd switched away from having a separate read-only connection for these queries, this had the undesirable side-effect of allowing write queries on the local state database. Switch back to using a separate read-only connection for local state. Morally this is a partial revert of #24, but done in a slightly different way.
danderson
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #25 I switched away from using a transaction for queries on the local state
database, because it did not interact properly with the queryable interface we
added in #24. But because I'd switched away from having a separate read-only
connection for these queries, this had the undesirable side-effect of allowing
write queries on the local state database.
Switch back to using a separate read-only connection for local state. Morally
this is a partial revert of #24, but done in a slightly different way.