Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First approach to Github Projects guidelines documentation #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rivasvict
Copy link
Collaborator

Hi @tecnoyucas/yucazos

This PR seeks to solve #10 Issue about GitHub projects guidelines.

Please review this pull request and also let's discuss about this document. You might want to suggest some changes or new flows, I'm all ears 😄

Thanks.

@aitbw aitbw changed the title First approach to github projet guidelines documentation First approach to Github Projects guidelines documentation Feb 27, 2018

## General notes

### Some rules first about the project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if this was something like General rules for projects

- Use Todo lists (this can help to better define the scope of an issue
and the state of it).
- Please try not to create huge issues, make them as short and clear
scoped as possible. If you need some sort of complex issue, please
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think scoped slipped in here 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aitbw Why do you say it is slipped?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never heard of short and clear scoped before

and the state of it).
- Please try not to create huge issues, make them as short and clear
scoped as possible. If you need some sort of complex issue, please
brake it down into smaller pieces.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Change it for break

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks

@aitbw
Copy link
Member

aitbw commented Feb 27, 2018

One final change, @vctr90: Could you please move this file to this folder? There's an empty file there especially for this document

Other than that, I agree with this draft 😄

@rivasvict
Copy link
Collaborator Author

@aitbw Please review again. Thanks.

@aitbw
Copy link
Member

aitbw commented Feb 27, 2018

Please, include this document here or delete that file to avoid duplicates 😌

@rivasvict
Copy link
Collaborator Author

Done @aitbw

2. Every single pull request MUST be associated with a GitHub issue
3. Whenever you close a pull request or comment on an issue, please
make sure to agree on issue completion.
4. All issues should have a deliverable product (a document or a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not consistent with our current DO NOT REMOVE issues. Let’s rephrase this to be relative to the Publication-N repos and not the meta repo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadasant When I say "deliverable product", I mean, a generic way to give a "tangible" solution for an issue, the issue could be related or not to a publication. For example, this is not a document considered as TecnoYucas publication, therefore, it is just a guideline document, a "deliverable product" of this issue. What I can do is to put a note that states that a "Deliverable product" could also be a Publication-N.

I am guessing TecnoYucas will be wider than just publications. We will be doing things not related to publications. For example: A merged feature, is a "deliverable product" of an issue but as you know, it does not have necessarily be a publication-related issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I understand that, I think. However, we have created issues that have no deliverables, which are our DO NOT REMOVE issues. We use them as a place to communicate. These issues were created with the goal of not removing them for now. What are your thoughts around that?


1. When an issue is newly created, it will directly go into `Inbox
(Not approved yet)` column
2. After an issue is approved (by at least **two** members of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can automate this if we use waffle instead of github projects and treat the boards to use labels, so an issue can go from Inbox to To do (Approved) as soon as someone assigns him/herself to the issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I can investigate and set a project in Waffle, what do you think @sadasant ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used Waffle, but Github Projects have something similar: https://help.github.com/articles/configuring-automation-for-project-boards/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Well, essentially: all of the columns should be automated based on tags, once we do that, I'll be comfortable with having rules around this. None of this process should be manual (except for some of the issue assignment at least)

@stefanmaric
Copy link
Member

Please, include this document here or delete that file to avoid duplicates

I think this pretty much fits what CONTRIBUTING.md is for and should be placed into that file as such for Github to catch it: https://help.github.com/articles/setting-guidelines-for-repository-contributors/

This is a very widespread practice, to not call it standard, that helps newcomers discover valuable information about the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants