allow user of ConnectionPool to override default tedious version #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
700software
approved these changes
Dec 7, 2020
|
I'm creating https://github.com/700software/tedious-connection-pool2 to have this change. |
|
@700software FYI, there's another branch I don't think I created a pull request for. I don't know if it's relevant for your use-case, but I found it useful when using prepared statements: https://github.com/SensusDA/tedious-connection-pool/commits/suppress-reset |
|
@andrewsensus, I'd like you to make PR to tedious-connection-pool2 if you think it would be helpful to the open source community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ConnectionPool.overrideTedious(tedious) to create connections using specified tedious module rather than ConnectionPool's default version of tedious.
Related Issue
Issue #43
Motivation and Context
ConnectionPool requires a version of tedious; users of ConnectionPool might wish to update tedious on a different schedule than ConnectionPool updates tedious.
How Has This Been Tested?
An internal project has been running with this change and an updated version of tedious for months. Testing is primarily on Linux but includes OS X and Windows as well.
Types of changes
This is not a breaking change because using the new method is optional. If the new method is not called, ConnectionPool continues to use the same version of tedious it has been using.
Checklist:
Any suggestions on what tests should be added? Perhaps there's some clever trick to pull in multiple versions of tedious under different names. Perhaps a test should wrap tedious.Connection and verify the wrapper got called?