Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new financial-calculating #29

Merged
merged 16 commits into from
Jan 9, 2025
Merged

feat: new financial-calculating #29

merged 16 commits into from
Jan 9, 2025

Conversation

arashagp
Copy link
Member

@arashagp arashagp commented Jan 6, 2025 •
edited
Loading

Description

Tasks

  • 📝 Self-Review: Ensure that you have thoroughly reviewed your own code changes.
  • 📚 Code Documentation: Update or create all necessary documentation within the code.
  • 📖 User Guides: Add necessary guides to the help document, including README or other help files (if applicable).
  • 🎨 Formatting: Ensure that the code is properly formatted.
  • 📅 Daily Report: Record the changes in the company's daily report, if applicable.
  • 🔄 Rebase: Ensure your branch is rebased and updated based on the default branch.
  • ⬆️ GitHub Project & Assignee: Ensure this pull request is correctly assigned and added to the appropriate GitHub project with the correct status.
  • ✅ Local Deployment Testing (If Applicable): If the changes affect the application's functionality, deploy and test the application locally to ensure it functions as expected.

@arashagp arashagp added the new-feature New features or options. label Jan 6, 2025
@arashagp arashagp self-assigned this Jan 6, 2025
@arashagp arashagp requested a review from njfamirm as a code owner January 6, 2025 10:47
njfamirm
njfamirm requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@njfamirm njfamirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also write test

packages/financial-calculate/package.json Outdated Show resolved Hide resolved
packages/financial-calculate/package.json Outdated Show resolved Hide resolved
packages/financial-calculate/src/lib/calculate.ts Outdated Show resolved Hide resolved
packages/financial-calculate/src/lib/calculate.ts Outdated Show resolved Hide resolved
njfamirm
njfamirm reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@njfamirm njfamirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove non financial chanegs and do in other pr

packages/financial-calculate/README.md Outdated Show resolved Hide resolved
packages/financial-calculate/README.md Outdated Show resolved Hide resolved
packages/financial-calculate/src/lib/calculate.ts Outdated Show resolved Hide resolved
packages/financial-calculate/src/lib/calculate.ts Outdated Show resolved Hide resolved
@arashagp arashagp requested a review from njfamirm January 7, 2025 07:13
arashagp added 12 commits January 9, 2025 08:05
@arashagp @njfamirm
feat(financial-calculating): initial Document Calculating
3897585
@arashagp @njfamirm
docs(financial-calculate): enhance README and add detailed API docume…
68050d2 
…ntation
@arashagp @njfamirm
refactor(financial-calculate): update package.json files and improve …
7ac5003 
…function naming in calculate.ts
@arashagp @njfamirm
feat(financial-calculating): write test
865c16c
@arashagp @njfamirm
docs(financial-calculate): improve parameter descriptions in calculat…
6378f1d 
…e.ts
@arashagp @njfamirm
feat(financial-calculate): more and more test's
316f3d8
@arashagp @njfamirm
lint: Make Happy :)
0b113c9
@arashagp @njfamirm
docs(financial-calculate): fix name of package installation
c602307
@arashagp @njfamirm
refactor(financial-calculate): change name of functions
a317f92
@arashagp @njfamirm
docs(financial-calculate): change Api to API
dbcc7f3
@arashagp @njfamirm
refactor: remove files except anything about financial calculate
aea0f3c
@arashagp @njfamirm
chore(financial-calculate): rename all functions changed
92b0465
njfamirm
njfamirm previously approved these changes Jan 9, 2025
View reviewed changes
packages/financial-calculate/tsconfig.json Outdated Show resolved Hide resolved
@njfamirm njfamirm self-assigned this Jan 9, 2025
@njfamirm njfamirm changed the title feat(financial-calculating): initial Document Calculating feat: new financial-calculating Jan 9, 2025
@njfamirm njfamirm merged commit 63eaceb into next Jan 9, 2025
2 checks passed
@njfamirm njfamirm deleted the feat/financials branch January 9, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njfamirm njfamirm njfamirm left review comments

Assignees

@arashagp arashagp

@njfamirm njfamirm

Labels
new-feature New features or options.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arashagp @njfamirm