Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38050 - Add ip6 to search conditions for host_finder #10391

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ShimShtein
Copy link
Member

Make sure ip6 is also searched when looking for hosts in host_finder.

Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a machine with IPv6 2620:52:0:9f:6666::23.

When I run

curl -H "HTTP_X_FORWARDED_FOR: 2620:52:0:9f:6666::23" -H "REMOTE_ADDR: ::1" https://foreman.local.lan/unattended/provision

I got following error:

unattended: unable to find a host that matches the request from ::1

Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 It works!

I tried with a different setup, and the host has been found by the IPv6 address only.
I sent a request without a token, and the Mac address and the host have been updated.

@stejskalleos stejskalleos merged commit b4bd8e2 into theforeman:develop Jan 14, 2025
51 checks passed
@stejskalleos
Copy link
Contributor

Thanks @ShimShtein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants