Skip to content

Commit

Permalink
Merge pull request #16 from trallard/trallard/patch-3
Browse files Browse the repository at this point in the history
REL - Fix WCAG issues in theme
  • Loading branch information
trallard authored Sep 21, 2022
2 parents c1bf1a3 + b0df7f4 commit 8ca0637
Show file tree
Hide file tree
Showing 10 changed files with 689 additions and 73 deletions.
14 changes: 12 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@

All notable changes to the "pitaya-smoothie" extension will be documented in this file.

## Release 2.0.2

![FIX](https://img.shields.io/badge/-FIX-gray.svg?colorB=FC427B)

> ♿️ Fix comment and selection colours not meeting WCAG AA standards [`444121d`](https://github.com/trallard/pitaya_smoothie/commit/444121d)
![NEW](https://img.shields.io/badge/-NEW-gray.svg?colorB=12CBC4)

> 📝 Add colour contrast grid to README [`1351c6a`](https://github.com/trallard/pitaya_smoothie/commit/1351c6a)
## Release 2.0.1

![FIX](https://img.shields.io/badge/-FIX-gray.svg?colorB=FC427B)
Expand All @@ -25,8 +34,9 @@ All notable changes to the "pitaya-smoothie" extension will be documented in thi
> ✨ Ensure the UX palette is scalable and consistent [ab85fe](https://github.com/trallard/pitaya_smoothie/commit/ab85fe)
> ✨ Improve highlight colours for better visibility [e717e8](https://github.com/trallard/pitaya_smoothie/commit/e717e8)
> ✨ Rearrange the themes to have groups of tokens [3fb5c0f](https://github.com/trallard/pitaya_smoothie/commit/3fb5c0f8a2e5e53e48fc62f12efdb2f08e3b8f31)
> ✨ Fix merge colours - now AAA compliance [3e9716](https://github.com/trallard/pitaya_smoothie/commit/3e9716bc0b2ef0673763315b373ddb1b7fe93899)
> ✨ Fix merge colours - now AAA compliance [3e9716](https://github.com/trallard/pitaya_smoothie/commit/3e9716bc0b2ef0673763315b373ddb1b7fe93899)
> ✨ Reduce number of highlight colours [cf12b0](cf12b0c37b1eeb90cf032f0b1e822d121c3f8f24)
## RELEASE: 1.0.5

![FIX](https://img.shields.io/badge/-FIX-gray.svg?colorB=FC427B)
Expand All @@ -40,7 +50,7 @@ All notable changes to the "pitaya-smoothie" extension will be documented in thi

![FIX](https://img.shields.io/badge/-FIX-gray.svg?colorB=FC427B)

> ✨ Multiple improvements to general accesibility: [highlighting](https://github.com/trallard/pitaya_smoothie/commit/512a3ef), [debugging](https://github.com/trallard/pitaya_smoothie/commit/0c755e9), [error and warning](https://github.com/trallard/pitaya_smoothie/commit/8b697eb)
> ✨ Multiple improvements to general accessibility: [highlighting](https://github.com/trallard/pitaya_smoothie/commit/512a3ef), [debugging](https://github.com/trallard/pitaya_smoothie/commit/0c755e9), [error and warning](https://github.com/trallard/pitaya_smoothie/commit/8b697eb)
> ✨ Remove deprecated theme tags [5c782e2](https://github.com/trallard/pitaya_smoothie/commit/5c782e2)
## RELEASE: 1.0.3
Expand Down
697 changes: 651 additions & 46 deletions README.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion demo-scripts/dart-flutter.dart
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ class PitayaStyle {
// https://github.com/trallard/pitaya_smoothie
static const Color PitayaBackground = Color(0xFF181036);
static const Color PitayaForeground = Color(0xFFFEFEFF);
static const Color PitayaComment = Color(0xFF5C588A);
static const Color PitayaComment = Color(0xFF8786ac);
static const Color PitayaKeyword = Color(0xFFF26196);
static const Color PitayaString = Color(0xFF7998F2);
static const Color PitayaNumber = Color(0xFFF3907E);
Expand Down
2 changes: 1 addition & 1 deletion demo-scripts/dummy.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,4 @@

## COMMENTS

`#7E7AAA` - double slashed comments
`#8786ac` - double slashed comments
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
</div>

<div class="footer">
<p>This theme was created for you with by <a href="http://twitter.com/ixek">Tania Allard</a>
<p>This theme was created for you with 💜 by <a href="http://twitter.com/ixek">Tania Allard</a>
</p>
</div>

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "pitaya-smoothie",
"displayName": "Pitaya smoothie",
"description": "A dark editor theme with handpicked colours and heavily inspired by the ultraviolet colour (colour of the year 2018) and Outrun aesthetics. A theme with contrast and accessibility for colourblindess in mind.",
"version": "2.0.1",
"version": "2.0.2",
"publisher": "trallard",
"author": {
"name": "Tania Allard"
Expand Down
17 changes: 9 additions & 8 deletions stylesheet.css
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
/* styles for basic website */

body {
background: #181e44;
font-family: 'PT Mono', 'Courier New', Courier, monospace;
background: #181036;
font-family: "PT Mono", "Courier New", Courier, monospace;
color: #fefeff;
font-size: 22px;
line-height: 1.4em;
}

a {
color: #7998F2;
color: #7998f2;
}

strong{
color: #F85E9F;
strong {
color: #f85e9f;
}

.title, .screenshot {
.title,
.screenshot {
width: 100%;
margin-top: 50px;
}
Expand All @@ -30,7 +31,8 @@ strong{
margin-bottom: 50px;
}

.title img, .screenshot img{
.title img,
.screenshot img {
display: block;
margin-left: auto;
margin-right: auto;
Expand All @@ -51,4 +53,3 @@ table {
margin-top: 50px;
border-spacing: 2rem;
}

8 changes: 4 additions & 4 deletions themes/Copy-italic.json
Original file line number Diff line number Diff line change
Expand Up @@ -1082,7 +1082,7 @@
"comment.block.html",
],
"settings": {
"foreground": "#7E7AAA",
"foreground": "#8786ac",
"fontStyle": "italic"
}
},
Expand Down Expand Up @@ -1186,7 +1186,7 @@
"meta.diff.header.from-file"
],
"settings": {
"foreground": "#7E7AAA"
"foreground": "#8786ac"
}
},
{
Expand Down Expand Up @@ -1381,7 +1381,7 @@
"name": "Double-Slashed Comment",
"scope": "comment.line.double-slash",
"settings": {
"foreground": "#7E7AAA"
"foreground": "#8786ac"
}
},
{
Expand Down Expand Up @@ -1444,7 +1444,7 @@
"punctuation.definition.comment",
],
"settings": {
"foreground": "#7E7AAA",
"foreground": "#8786ac",
"fontStyle": "italic"
}
},
Expand Down
8 changes: 4 additions & 4 deletions themes/Pitaya-smoothie-color-theme-noitalic.json
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@
"comment.block.html"
],
"settings": {
"foreground": "#7E7AAA"
"foreground": "#8786ac"
}
},
// JSON
Expand Down Expand Up @@ -1170,7 +1170,7 @@
"meta.diff.header.from-file"
],
"settings": {
"foreground": "#7E7AAA"
"foreground": "#8786ac"
}
},
{
Expand Down Expand Up @@ -1363,7 +1363,7 @@
"name": "Double-Slashed Comment",
"scope": "comment.line.double-slash",
"settings": {
"foreground": "#7E7AAA"
"foreground": "#8786ac"
}
},
{
Expand Down Expand Up @@ -1425,7 +1425,7 @@
"punctuation.definition.comment",
],
"settings": {
"foreground": "#7E7AAA"
"foreground": "#8786ac"
}
},
{
Expand Down
10 changes: 5 additions & 5 deletions themes/Pitaya-smoothie-color-theme.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"editorLineNumber.activeForeground": "#18C1C4",
"editorCursor.foreground": "#F85E9F", // Color of the editor cursor.
// Editor - Highlight and selection
"editor.selectionBackground": "#301C7ABD", // Color of the editor selection. -psbright-600
"editor.selectionBackground": "#231458d6", // Color of the editor selection. -psbright-600
"editor.inactiveSelectionBackground": "#221068DB", // Color of the selection in an inactive editor. The color must not be opaque to not hide underlying decorations.
"editor.selectionHighlightBackground": "#301C7ABD", // Color for regions with the same content as the selection. The color must not be opaque to not hide underlying decorations.
"editor.selectionHighlightBorder": "#863BFF8F",
Expand Down Expand Up @@ -1081,7 +1081,7 @@
"comment.block.html",
],
"settings": {
"foreground": "#7E7AAA",
"foreground": "#8786ac",
"fontStyle": "italic"
}
},
Expand Down Expand Up @@ -1185,7 +1185,7 @@
"meta.diff.header.from-file"
],
"settings": {
"foreground": "#7E7AAA"
"foreground": "#8786ac"
}
},
{
Expand Down Expand Up @@ -1380,7 +1380,7 @@
"name": "Double-Slashed Comment",
"scope": "comment.line.double-slash",
"settings": {
"foreground": "#7E7AAA"
"foreground": "#8786ac"
}
},
{
Expand Down Expand Up @@ -1443,7 +1443,7 @@
"punctuation.definition.comment",
],
"settings": {
"foreground": "#7E7AAA",
"foreground": "#8786ac",
"fontStyle": "italic"
}
},
Expand Down

0 comments on commit 8ca0637

Please sign in to comment.