Fix:Empty link in record details isn't deleted by default #9840
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds functionality to handle empty link deletion in record details, ensuring that empty links are properly removed when a user clears the input field.
- Added
isClearingInputstate inMultiItemFieldInput.tsxto track input clearing status - Modified
handleSubmitInputto trigger item deletion when input is cleared - Improved empty string validation using
turnIntoEmptyStringIfWhitespacesOnlyutility - Integrated with existing link field components to maintain consistent behavior
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
86
to
87
| if (value === '' && itemToEditIndex !== null) { | ||
| setIsClearingInput(true); |
There was a problem hiding this comment.
logic: comparing with !== null here is incorrect since itemToEditIndex is a number. Should use !== -1 to match initialization
Comment on lines
138
to
139
| if (isClearingInput && itemToEditIndex !== null) { | ||
| handleDeleteItem(itemToEditIndex); |
There was a problem hiding this comment.
logic: same issue here with !== null comparison for itemToEditIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a fix for #9780 . I have added handleDelete inside the submit function and created a state to manage the empty placeholder
Screencast from 2025-01-24 01-45-22.webm