Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): Disabled Select should use color-background #4191

Merged
merged 3 commits into from
Dec 18, 2024
Merged

fix(select): Disabled Select should use color-background #4191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc29ce0
fix(select): use parent for background color in disabled state
PixeledCode Dec 17, 2024
1c3b0d6
fix(select): add changeset
PixeledCode Dec 17, 2024
2e5dbc0
Merge branch 'main' into fix-select-bg
kodiakhq[bot] Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/hungry-countries-move.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@twilio-paste/select": patch
"@twilio-paste/core": patch
---

[Select]: Fix wrong background color during disabled state
1 change: 1 addition & 0 deletions packages/paste-core/components/select/src/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export const SelectElement = React.forwardRef<HTMLSelectElement, SelectProps>(
width="100%"
_disabled={{
color: variant === "inverse" ? "colorTextInverseWeakest" : "colorTextWeaker",
backgroundColor: "transparent",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any way of testing this on windows? might be safer to set it to the actual desired token for disabled rather than transparent

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on my personal windows using the deploy preview. I compared it against what is currently in prod and works for both light and dark themes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used browerstack to test it and works for me too

cursor: "not-allowed",
opacity: 1,
}}
Expand Down
Loading