-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: include Vuetify SASS variables overriding #288
Conversation
SAAS variable overriding was difficult to figure out how to configure using this module. Provide some sample documentation for how to get it to work.
Move the entry using h2 ( Myabe we can change the menu title here https://nuxt.vuetifyjs.com/guide/sass-modern-compiler.html to |
/cc @TechAkayy |
For some reason my tired brain was thinking Software as a Service, rather than SASS. Replace them all.
Use 'other options' verbiage instead of comment with ellipsis for clarity
Per PR review, moving the contents of saas-variables.md (sic, sorry) to sass-modern-compiler.md as a sub-section.
@userquin thanks for the speedy review! Happy to make more changes as you or @TechAkayy see fit. |
Reference SASS Modern Compiler sub-section in Server Side Rendering doc
Change VP config file entry here (set text to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two more minor feedbacks. Otherwise, it reads really good. Anyone using our module will find this very valuable. Thanks bunch @anonmos 👍
By the way, renaming main.scss
to global.scss
is really a good idea, I will update my sample repos too. On the same line, wondering if renaming settings.scss
to components.scss
makes sense, thoughts @anonmos? @userquin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
Description
Overriding SASS variables was difficult to figure out when using this module. Provide some sample documentation for getting it to work.
Linked Issues
N/A
Additional Context
Out of the box the documentation on the Vuetify site does not provide a way to get a working example up and running for overriding SASS variables that is compatible with the Vuetify Nuxt Module. Additionally there is no existing documentation on this module's page for getting it to work.
This extra md file provides step-by-step instructions for configuring SASS variable overrides that work with this Nuxt module.
Tip
The author of this PR can publish a preview release by commenting
/publish
below.