Deployment docs extras #2443
Open
Deployment docs extras #2443
+85
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
approved these changes
Jan 10, 2025
| If you want to set up a custom domain for your Wasp app, you can do it for both the client and the server. | ||
|
|
||
| You point users to visit your client app, so setting up the custom domain for the client is the impactful part. Setting up a custom domain for the server is optional, but it can be useful if you'd like to hide the actual server domain from the users. |
There was a problem hiding this comment.
The first sentence was a little weird to me, maybe we can turn it around:
The important part is setting up the custom domain for the client - that's what your users visit from their browsers.
| You need to set the environment variables so Wasp configures the app correctly (for example, for CORS to work correctly). | ||
|
|
||
| **For the client**, you need to set the `REACT_APP_API_URL` environment variable to the **server domain** when [building the client](./env-vars.md#client-env-vars). |
There was a problem hiding this comment.
Maybe we can have two subsections: client and server instead of "For the client" and "For the server"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will: