Add docs for how web-features syncs with BCD #2560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
captainbrosset
requested changes
Jan 21, 2025
|
Thanks for the review, Patrick, and the partial review, Daniel! I updated this PR to avoid the word "workflow". This might use GitHub actions/workflows but it really is an implementation detail. The goal of this document is more for maintainers to understand how BCD and web-features work together and how compat_feature lists and BCD tags are synchronized conceptually. |
jamesnw
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
This looks good!
I'm wondering about a high level TLDR, something like "Either way is fine. If you're authoring a new feature, add the keys in web-features. If you're changing keys in BCD, make the change there. The goal is to limit the times where you have to make PRs in both repositories."
Co-authored-by: James Stuckey Weber <[email protected]>
tidoust
reviewed
Jan 24, 2025
Co-authored-by: François Daoust <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1672 (comment)