feat: make bun understand yarn pnp #924
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
jwoo0122
commented
Jan 22, 2025
There was a problem hiding this comment.
I made a real yarn workspace to test real pnp api, but it'll be good to see any ideas for this fixture.
|
It turns out that running all test code in series global variable in helpers ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make knip understand yarn pnp. It can now look into manifest files inside yarn cache, and correctly check peer dependency.
Maybe we can make this feature to be enabled with yarn plugin made from #864 but I didn't find any hint to patch manifest helpers from plugin.