Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [[ViewedArrayBuffer]].[[ByteLength]] name in ReadableStreamBYOBRequest doc #1337

Conversation

Taym95
Copy link
Contributor

@Taym95 Taym95 commented Jan 19, 2025

While working on ReadableStreamBYOBRequest in Servo, we noticed that [[ViewedArrayBuffer]].[[ArrayBufferByteLength]] was wrongly used instead of [[ViewedArrayBuffer]].[[ByteLength]] in ReadableStreamBYOBRequest doc.

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno: …
    • Node.js: …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@domenic
Copy link
Member

domenic commented Jan 21, 2025

This is blocked on #1337, which should get merged soon.

Additionally, can you or your company sign the participant agreement?

@Taym95
Copy link
Contributor Author

Taym95 commented Jan 21, 2025

This is blocked on #1337, which should get merged soon.

Additionally, can you or your company sign the participant agreement?

Yes I signed it and my name was added in whatwg/participant-data@0495a7b

…Request doc

`[[ViewedArrayBuffer]].[[ArrayBufferByteLength]]` was used wrongly instead of `[[ViewedArrayBuffer]].[[ByteLength]]` ReadableStreamBYOBRequest
@domenic domenic force-pushed the fix-ViewedArrayBuffer-ByteLength-name-in-ReadableStreamBYOBRequest-doc branch from 0a1a72c to 705e435 Compare January 22, 2025 01:29
@domenic domenic merged commit 2811932 into whatwg:main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants