[WFCORE-7116] Remove ModuleIdentifier from Extension handling #6304
Conversation
bstansberry
force-pushed
the
WFCORE-7116
branch
from
43e45db to
1d34f6b
Compare
| @@ -3809,4 +3809,7 @@ OperationFailedRuntimeException capabilityAlreadyRegisteredInContext(String capa | |||
| @LogMessage(level = WARN) | |||
| @Message(id = 517, value = "There are multiple Parallel Boot Operations.") | |||
| void multipleParallelBootOperation(); | |||
|
|
|||
| @Message(id = 518, value = "Resource /extension=%s uses a non-canonical module name; use the canonical form %s") | |||
There was a problem hiding this comment.
Perhaps, I would add in the message a short hint about what a canonical form is. Something like:
"Resource /extension=%s uses a non-canonical module name; use the canonical form %s. The canonical representation includes slot information in the module name if the slot is not 'main'"
| // This isn't a full canonicalization, but extension module names are unlikely to be non-canonical | ||
| // in any way beyond maybe a trailing ":main". So just check for and strip any trailing ":main" |
There was a problem hiding this comment.
question: Did you consider adding a ModuleIdentifierUtil version to the wildfly-controller-client module so we can have the utility available on the client code?
There was a problem hiding this comment.
I hadn't no, but I updated this to move the main code to controller-client and have the controller module class just delegate to the client class.
I wouldn't want to do too much of this kind of thing, as its kind of an edge case for controller-client. But after almost 15 years we have hardly any of these, so I think it's ok. ;-)
...ntroller/src/main/java/org/jboss/as/domain/controller/operations/ApplyExtensionsHandler.java
Show resolved
Hide resolved
bstansberry
force-pushed
the
WFCORE-7116
branch
from
1d34f6b to
3b7ef2d
Compare
https://issues.redhat.com/browse/WFCORE-7116