Fixes Deep Compare #35
Conversation
| return; | ||
| } | ||
|
|
||
| assert.equal(obj[key], content[key]); | ||
| if (Array.isArray(content[key]) && !content[key].length && actualValue === undefined) { |
There was a problem hiding this comment.
&& actualValue === undefined
No tests fail if this is removed - both here and later on. Either there's some missing unit test to be added or these checks aren't necessary and can be removed. Either way, could you check and make the right change please?
| @@ -25,11 +25,11 @@ describe('yeoman-assert', () => { | |||
|
|
|||
| it('reject a file that does not exist', () => { | |||
| assert.throws(yoAssert.file.bind(yoAssert, 'etherealTestFile')); | |||
| }); | |||
| }, /.*AssertionError.*/); | |||
There was a problem hiding this comment.
Suggestion: I'd revert these. I don't plan on blocking on this, but just stating a preference: I don't think these are worth adding. Nothing prevents the comments from getting out of date. And we already know some error is being thrown. If we really wanted to assert on which error that is, we can always check its class/constructor/name.
Totally up to you though, feel free to ignore this suggestion. 🙂
|
Btw, in case you're wondering why this took almost four years to review: yeoman/yeoman#1779. 🎩 |
Resolves #34
Plus I refactored in the separate commit tests, to be more resilient to similar errors.