Player fixes #1789
Player fixes #1789
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 14305798 | Triggered | Google API Key | 2a9007f | innertube/src/main/java/com/zionhuang/innertube/models/YouTubeClient.kt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
@z-huang can you have a look? There is one last thing I'm not sure about. The http clients in What do you think? Should the proxy be removed? |
|
The crashing after logging in seems to be fixed in the latest commit build! (However, the youtube music webpage is opened after logging in successfully, it would maybe be better if it exited out of the login prompt automatically, after logging in successfully) EDIT: Playing songs, as well as downloading, also works of course! |
|
Works great! Only issue is increased startup time and decreased UI performance on a lower end device like mine (Cat S22 Flip). It takes about 10-15 seconds for my phone to start it up, and then the UI renders slowly (5-10 FPS when scrolling) |
@MLGHerobrine if you used the link to download the debug version, that is normal. I haven't tested but I assume that when building the release APK, performance should be as usual. |
|
Proxy support is now also added. Turns out it wasn't hard because the proxy is only applied on app start. This means if you change the proxy settings you will have to fully close and restart the app. That was already the case before and just made adding the proxy to the new http clients easier. |
|
This video won't play or download when you sign in. I have selected "high" for audio quality and it shows mp4 in the details: https://music.youtube.com/watch?v=wxHRqPtWHOU
|
@Figim Please follow these steps: 1.) Clear app data (full reset without restoring a backup)
This PR does not change anything about the code which chooses the format. "high" in InnerTune just means the format with the highest bitrate (for you). This could be improved in the future but for now you get the same formats as with older InnerTune versions. |
2. Playing this video |
|
I updated to the latest version after the comment. FATAL EXCEPTION: main |
I updated the app to this comment version and now it crashes when I play all videos or songs App crashes while completing account creation in Settings |
This is a know problem with the full version of this app. You have to download the foss version for now.
Probably also due to Firebase. Use the foss version. |
But that video still doesn't play. For account |
Did you reset the app again? (without loading a backup) if it still doesn't work please post the log |
I've downloaded app-foss from here (latest CI run)
No account |
In the Foss version, everything works with the account. Does the account we log into in the Foss version affect starting playback? |
|
@ecomaikgolf thanks for testing
If you are logged in the player will use the account unless there is an error with it in which case it will try again without the account. |
Maybe it can't play with the account. But we can't say it changes automatically. |
You can check with a debugger. |
1736519578.352 10416 13781 13781 I ViewRootImpl@b4edb90[MainActivity]: handleAppVisibility mAppVisible=false visible=true |
|
@Figim you won't find it in the debug logs. You will have to use an actual debugger and set a breakpoint in Another way to see if the account was used is by looking at the network requests. |
…pe, "Player fixes z-huang#1789", además se ha solucionado un problema con la Joss Red sobre la reproducción, ahora puede activarlo desde el apartado de Joss Red
Should fix #1748 #1781 #1775 #1770 #1758 #1764 #1760 #1757 #1787 #1788 #1790
This supersedes #1774 with additional improvements.
Compared to the previous PR this adds:
songUrlCacheCurrent test build:
https://github.com/z-huang/InnerTune/actions/runs/12721306256/artifacts/2416374758