Proxy Danger requests through a proxy service #10395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Danger to proxy its requests to GitHub through a proxy service.
Motivation
Currently Danger is not able to run on PRs opened from forks of Zed.
This is due to GitHub Actions' security policies. Forks are not able to see any of the repository secrets, and the built-in
secrets.GITHUB_TOKEN
has its permissions restricted to only reads when running on forks.I asked around on the Danger repo, and some big projects (DefinitelyTyped) are working around this by using a publicly-listed (although slightly obfuscated) token: danger/danger-js#918 (comment).
While this approach is probably okay given the limited scope and permissions of the GitHub token, I would still prefer a solution that avoids disclosing the token at all.
Explanation
I ended up writing a small proxy service, Danger Proxy, that can be used to provide Danger with the ability to make authenticated GitHub requests, but without disclosing the token.
From the README:
I have an instance of this service deployed to danger-proxy.fly.dev.
Release Notes: