Delay hiding git blame tooltip #22644
Open
+389
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mgsloan
force-pushed
the
delay-hiding-hoverable-tooltips
branch
from
3dcde67 to
c553512
Compare
mgsloan
force-pushed
the
delay-hiding-hoverable-tooltips
branch
10 times, most recently
from
20203a4 to
063e920
Compare
It's easy to overshoot the bottom of the tooltip when cursoring to a button, such as opening the commit from a blame tooltip. Before this change the tooltip would immediately disappear, and now it sticks around for a bit. Also: * Shares the implementation with `elements/text.rs`. This will particularly be handy when it makes use of hoverable tooltips. Also means that it will use the same handling for mouse down / mouse wheel (it did not handle mouse wheel before). * Improves the fix to #21657. - Now the element will no longer think it has an active tooltip that it registers with the window. - It will instead display the next available tooltip, whereas I believe before the next available tooltip would be suppressed. * Fixes bug where `cx.refresh()` wasn't called when text tooltip is hidden due to a mouse down event. * Ports over fix in #14832 to `elements/text.rs`
mgsloan
force-pushed
the
delay-hiding-hoverable-tooltips
branch
from
063e920 to
9cb70b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to overshoot the bottom of the tooltip when cursoring to a button, such as opening the commit from a blame tooltip. Before this change the tooltip would immediately disappear, and now it sticks around for a bit.
Also:
Shares the implementation with
elements/text.rs. This will particularly be handy when it makes use of hoverable tooltips.Improves the fix to Tooltip stuck on screen #21657.
Now the element will no longer think it has an active tooltip that it registers with the window.
It will instead display the next available tooltip, whereas I believe before the next available tooltip would be suppressed.
Fixes bug where
cx.refresh()wasn't called when text tooltip is hidden due to a mouse down event.Ports over fix in Fix tooltips sometimes continuously displaying when the button is selected #14832 to
elements/text.rsRelease Notes: