Update call to FhirToHl7Converter to pass in correct BlobContainerMetadata #16505

arnejduranovic · 2024-11-07T22:00:49Z

Updates the call to FhirToHl7Converter in Receiver.consistencyErrorMessage to use the correct BlobContainerMetadata that points to the correct container (metadata) in the Storage Container.

I think why this stopped working at some point is because we decided to move where we store these yaml files and didn't update this one location, but I can't confirm 100%.

Test Steps:

Upload prime-router/src/main/resources/metadata/hl7_mapping/ORU_R01/ORU_R01-deidentified.yml to your local storage container under the expected path:
Confirm the multiple-settings update command works:

~/Projects/prime-reportstream/prime-router git:[master]
./prime multiple-settings set -i settings/STLTs/HHS-Protect/hhs-protect.yml -e local
settings/STLTs/HHS-Protect/hhs-protect.yml is valid!

1 YAML files validated!
Waiting for the API at http://localhost:7071 to be available...
Loading settings from /Users/arnej/Projects/prime-reportstream/prime-router/settings/STLTs/HHS-Protect/hhs-protect.yml...
 entity type |             entity name |                      setting name |          environment value |                                            file value
-------------|-------------------------|-----------------------------------|----------------------------|------------------------------------------------------
organization |              hhsprotect |                        countyName |                            |                                                  null
organization |              hhsprotect |                         createdAt | "2024-11-06T20:56:45.089Z" |                                                      
organization |              hhsprotect |                         createdBy |           "[email protected]" |                                                      
organization |              hhsprotect |                      featureFlags |                            |                                                  null
organization |              hhsprotect |                           filters |                            |                                                  null
organization |              hhsprotect |                              keys |                            |                                                  null
organization |              hhsprotect |                         stateCode |                            |                                                  null
organization |              hhsprotect |                           version |                          0 |                                                      
    receiver | hhsprotect.mars-otc-elr |                    customerStatus |                            |                                              "active"
    receiver | hhsprotect.mars-otc-elr |                    dateTimeFormat |                            |                                              "OFFSET"
    receiver | hhsprotect.mars-otc-elr |                 deidentifiedValue |                            |                                      "<DEIDENTIFIED>"
    receiver | hhsprotect.mars-otc-elr |                        deidentify |                            |                                                  true
    receiver | hhsprotect.mars-otc-elr |                       description |                            |                                                    ""
    receiver | hhsprotect.mars-otc-elr |                      externalName |                            |                                                  null
    receiver | hhsprotect.mars-otc-elr |           jurisdictionalFilter[0] |                            |                                                "true"
    receiver | hhsprotect.mars-otc-elr |                              name |                            |                                        "mars-otc-elr"
    receiver | hhsprotect.mars-otc-elr |                  organizationName |                            |                                          "hhsprotect"
    receiver | hhsprotect.mars-otc-elr |           reverseTheQualityFilter |                            |                                                 false
    receiver | hhsprotect.mars-otc-elr |                          timeZone |                            |                                                  null
    receiver | hhsprotect.mars-otc-elr |                timing.initialTime |                            |                                               "00:02"
    receiver | hhsprotect.mars-otc-elr |             timing.maxReportCount |                            |                                                  1000
    receiver | hhsprotect.mars-otc-elr |               timing.numberPerDay |                            |                                                  1440
    receiver | hhsprotect.mars-otc-elr |                  timing.operation |                            |                                               "MERGE"
    receiver | hhsprotect.mars-otc-elr |                   timing.timeZone |                            |                                             "EASTERN"
    receiver | hhsprotect.mars-otc-elr |           timing.whenEmpty.action |                            |                                                "NONE"
    receiver | hhsprotect.mars-otc-elr |   timing.whenEmpty.onlyOncePerDay |                            |                                                 false
    receiver | hhsprotect.mars-otc-elr |                             topic |                            |                                        "mars-otc-elr"
    receiver | hhsprotect.mars-otc-elr |                translation.format |                            |                                                 "HL7"
    receiver | hhsprotect.mars-otc-elr |            translation.nameFormat |                            |                                            "STANDARD"
    receiver | hhsprotect.mars-otc-elr | translation.receivingOrganization |                            |                                                  null
    receiver | hhsprotect.mars-otc-elr |            translation.schemaName |                            | "azure:/hl7_mapping/ORU_R01/ORU_R01-deidentified.yml"
    receiver | hhsprotect.mars-otc-elr |                  translation.type |                            |                                              "CUSTOM"
    receiver | hhsprotect.mars-otc-elr |           translation.useBatching |                            |                                                 false
    receiver | hhsprotect.mars-otc-elr |          transport.credentialName |                            |                                        "DEFAULT-SFTP"
    receiver | hhsprotect.mars-otc-elr |                transport.filePath |                            |                                            "./upload"
    receiver | hhsprotect.mars-otc-elr |                    transport.host |                            |                                                "sftp"
    receiver | hhsprotect.mars-otc-elr |                    transport.port |                            |                                                  "22"
    receiver | hhsprotect.mars-otc-elr |                    transport.type |                            |                                                "SFTP"

Perform the above changes [y/N]: y
Success. Setting hhsprotect at version find version in: {
  "name" : "hhsprotect",
  "description" : "HHSProtect",
  "jurisdiction" : "FEDERAL",
  "version" : 1,
  "createdBy" : "[email protected]",
  "createdAt" : "2024-11-07T22:05:43.192Z"
}
Success. Created hhsprotect.mars-otc-elr

Delete that file and confirm the command returns the not found error

Changes

Include a comprehensive list of changes in this PR
(For web UI changes) Include screenshots/video of changes

Checklist

Testing

Tested locally?
Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
(For Changes to /frontend-react/...) Ran npm run lint:write?
Added tests?

Process

Are there licensing issues with any new dependencies introduced?
Includes a summary of what a code reviewer should test/verify?
Updated the release notes?
Database changes are submitted as a separate PR?
DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes [BUG] Unable to update receiver schemaNames to point to azure #16498

To Be Done

Create GitHub issues to track the work remaining, if any

Migrate UP consistencyErrorMessage logic to Konform #17020

…adata

github-actions · 2024-11-07T22:01:03Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

prime-router/src/main/kotlin/Receiver.kt

arnejduranovic · 2024-11-07T22:08:56Z

prime-router/src/main/kotlin/Receiver.kt

+                    FhirToHl7Converter(
+                        translation.schemaName,
+                        BlobAccess.BlobContainerMetadata.build(
+                            "metadata",


Not good to have this string literal sprinkled throughout the codebase but this is our current pattern. This can be looked at as part of the "Manage Translation Schemas v2" EPIC currently expected for Q3 FY25.

Agreed. Maybe a constants file with all the container names?

github-actions · 2024-11-07T22:12:25Z

Test Results

1 265 tests ±0 1 261 ✅ ±0 7m 46s ⏱️ -15s
164 suites ±0 4 💤 ±0
164 files ±0 0 ❌ ±0

Results for commit 70edcb4. ± Comparison against base commit cccf16d.

♻️ This comment has been updated with latest results.

sonarqubecloud · 2024-11-07T22:21:55Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-11-07T22:32:56Z

Integration Test Results

60 files 60 suites 43m 30s ⏱️
428 tests 418 ✅ 10 💤 0 ❌
431 runs 421 ✅ 10 💤 0 ❌

Results for commit 70edcb4.

♻️ This comment has been updated with latest results.

jalbinson

Able to verify test steps and changes look good.

sonarqubecloud · 2025-01-10T15:43:45Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Update call to FhirToHl7Converter to pass in correct BlobContainerMet…

4b2ae86

…adata

arnejduranovic requested a review from a team as a code owner November 7, 2024 22:00

arnejduranovic added the platform Platform Team label Nov 7, 2024

arnejduranovic temporarily deployed to staging November 7, 2024 22:01 — with GitHub Actions Inactive

arnejduranovic marked this pull request as draft November 7, 2024 22:01

arnejduranovic commented Nov 7, 2024

View reviewed changes

Merge branch 'main' into platform/arnej/16498

3769957

arnejduranovic temporarily deployed to staging January 8, 2025 18:12 — with GitHub Actions Inactive

Update TODO comment in Receiver.consistencyErrorMessage

1b93d45

arnejduranovic temporarily deployed to staging January 8, 2025 19:00 — with GitHub Actions Inactive

arnejduranovic marked this pull request as ready for review January 8, 2025 19:00

jalbinson approved these changes Jan 9, 2025

View reviewed changes

Merge branch 'main' into platform/arnej/16498

70edcb4

arnejduranovic enabled auto-merge (squash) January 10, 2025 15:20

arnejduranovic temporarily deployed to staging January 10, 2025 15:20 — with GitHub Actions Inactive

arnejduranovic merged commit 9ec0a59 into main Jan 10, 2025
25 checks passed

arnejduranovic deleted the platform/arnej/16498 branch January 10, 2025 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update call to FhirToHl7Converter to pass in correct BlobContainerMetadata #16505

Update call to FhirToHl7Converter to pass in correct BlobContainerMetadata #16505

arnejduranovic commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading

arnejduranovic Nov 7, 2024 •

edited

Loading

jalbinson Jan 9, 2025

github-actions bot commented Nov 7, 2024 •

edited

Loading

sonarqubecloud bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024 •

edited

Loading

jalbinson left a comment

sonarqubecloud bot commented Jan 10, 2025

Update call to FhirToHl7Converter to pass in correct BlobContainerMetadata #16505

Update call to FhirToHl7Converter to pass in correct BlobContainerMetadata #16505

Conversation

arnejduranovic commented Nov 7, 2024 • edited Loading

Changes

Checklist

Testing

Process

Linked Issues

To Be Done

github-actions bot commented Nov 7, 2024 • edited Loading

Dependency Review

OpenSSF Scorecard

Scanned Manifest Files

arnejduranovic Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

jalbinson Jan 9, 2025

Choose a reason for hiding this comment

github-actions bot commented Nov 7, 2024 • edited Loading

Test Results

sonarqubecloud bot commented Nov 7, 2024

Quality Gate passed

github-actions bot commented Nov 7, 2024 • edited Loading

Integration Test Results

jalbinson left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 10, 2025

Quality Gate passed

arnejduranovic commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading

arnejduranovic Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading