Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update call to FhirToHl7Converter to pass in correct BlobContainerMetadata #16505

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Update call to FhirToHl7Converter to pass in correct BlobContainerMetadata #16505

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b2ae86
Update call to FhirToHl7Converter to pass in correct BlobContainerMet…
arnejduranovic Nov 7, 2024
3769957
Merge branch 'main' into platform/arnej/16498
arnejduranovic Jan 8, 2025
1b93d45
Update TODO comment in Receiver.consistencyErrorMessage
arnejduranovic Jan 8, 2025
70edcb4
Merge branch 'main' into platform/arnej/16498
arnejduranovic Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions prime-router/src/main/kotlin/Receiver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package gov.cdc.prime.router
import com.fasterxml.jackson.annotation.JsonIgnore
import gov.cdc.prime.router.azure.BlobAccess
import gov.cdc.prime.router.common.DateUtilities
import gov.cdc.prime.router.common.Environment
import gov.cdc.prime.router.fhirengine.translation.hl7.FhirToHl7Converter
import gov.cdc.prime.router.fhirengine.translation.hl7.SchemaException
import java.time.LocalTime
Expand Down Expand Up @@ -258,8 +259,14 @@ open class Receiver(
if (translation is CustomConfiguration) {
if (this.topic.isUniversalPipeline) {
try {
// This is already scheduled for deletion in https://github.com/CDCgov/prime-reportstream/pull/13313
FhirToHl7Converter(translation.schemaName, BlobAccess.defaultBlobMetadata)
// This is already scheduled for deletion in https://github.com/CDCgov/prime-reportstream/pull/13313/files#r1489489429
arnejduranovic marked this conversation as resolved.
Show resolved Hide resolved
FhirToHl7Converter(
translation.schemaName,
BlobAccess.BlobContainerMetadata.build(
"metadata",
Copy link
Collaborator Author

@arnejduranovic arnejduranovic Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not good to have this string literal sprinkled throughout the codebase but this is our current pattern. This can be looked at as part of the "Manage Translation Schemas v2" EPIC currently expected for Q3 FY25.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Maybe a constants file with all the container names?

Environment.get().storageEnvVar
)
)
} catch (e: SchemaException) {
return e.message
}
Expand Down